Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interoperability issues with draft-11 #45

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

dansarie
Copy link
Contributor

@dansarie dansarie commented Nov 4, 2024

Fix a couple of mentions of draft8 that should be draft11, plus an additional typo in the README. The issues were found during the IETF 121 Hackathon in Dublin.

@dansarie dansarie changed the title Fix a couple of mentions of draft8 that should be draft11, plus an ad… Fix interoperability issues with draft-11 Nov 7, 2024
@dansarie
Copy link
Contributor Author

dansarie commented Nov 7, 2024

The pull request now also fixes the interoperability issues with draft-11 clients. They were due to two different issues:

  • First, the SRV and VER tags were in the wrong order in src/tag.rs, causing errors when they were encountered in the correct order in requests. A more robust fix would probably be to compare tags by uint32 value when ordering them, since this will work even for unknown tags. The root cause of this error seems to be that the tags are ordered incorrectly in the draft (see Correct order of tags in table ietf-wg-ntp/draft-roughtime#16).
  • Responses did not include NONC tags, as required by the draft.

@int08h
Copy link
Owner

int08h commented Nov 8, 2024

Thank you so much for the draft11 fixes!

@int08h int08h closed this Nov 8, 2024
@int08h int08h reopened this Nov 8, 2024
@int08h int08h merged commit 58a4a2c into int08h:master Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants