Merge pull request #235 from Akxe/Memory_leak_fix#2

Fix memory leak on component destroy
intbot · Jan 2, 2024 · de283b3 · de283b3
2 parents 00cd641 + c914ed9
commit de283b3
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/src/ng2-pdfjs-viewer.component.ts b/lib/src/ng2-pdfjs-viewer.component.ts
@@ -1,10 +1,10 @@
-import { Component, Input, Output, OnInit, ViewChild, EventEmitter, ElementRef } from '@angular/core';
+import { Component, Input, Output, OnInit, OnDestroy, ViewChild, EventEmitter, ElementRef } from '@angular/core';
 
 @Component({
   selector: 'ng2-pdfjs-viewer',
   template: `<iframe title="ng2-pdfjs-viewer" [hidden]="externalWindow || (!externalWindow && !pdfSrc)" #iframe width="100%" height="100%"></iframe>`
 })
-export class PdfJsViewerComponent implements OnInit {
+export class PdfJsViewerComponent implements OnInit, OnDestroy {
   @ViewChild('iframe', { static: true }) iframe: ElementRef;
   static lastID = 0;
   @Input() public viewerId = `ng2-pdfjs-viewer-ID${++PdfJsViewerComponent.lastID}`;
@@ -341,4 +341,8 @@ export class PdfJsViewerComponent implements OnInit {
     //   pagemode = ${this.errorMessage}
     // `);
   }
+
+  ngOnDestroy(): void {
+    this.relaseUrl?.();
+  }
 }