-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump teaclave-sdk to v1.1.6-testing #1074 #1076
bump teaclave-sdk to v1.1.6-testing #1074 #1076
Conversation
fd58756
to
c6758fe
Compare
e814147
to
f049d52
Compare
09a21b4
to
09db4ef
Compare
2f0ffce
to
9c34a8e
Compare
…n enclave-runtime
a214cf8
to
4108018
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor issue, we should investigate. Otherwise, it looks very good! Thanks for fighting this war. :)
TlsStream(RustlsStream), | ||
TlsStream(Box<RustlsStream>), | ||
WebSocketHandshake(RustlsMidHandshake), | ||
EstablishedWebsocket(RustlsWebSocket), | ||
EstablishedWebsocket(Box<RustlsWebSocket>), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this one also because of a big discrepancy between enum variant sizes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will add it to the PR description as well.
Cargo.lock
Outdated
name = "sgx_crypto_helper" | ||
version = "1.1.5" | ||
source = "git+https://github.com/apache/incubator-teaclave-sgx-sdk?tag=v1.1.5#d2d339cbb005f676bb700059bd51dc689c025f6b" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should investigate where this dependency comes from. I am a bit wary of using an old one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to have come from core/tls-websocket-server/Cargo.toml
.
Fixed this in bd750ad.
I will check the patches section of the cargo workspace
though, It should have been overridden by that. 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, patches don't work across different versions.
Thanks for fixing it! ❤️
Thank you so much for the detailed pr descriptions. It is a bliss. : 🚀 |
This PR aims to:
Fixes #1000
Unblocks Update polkadot-v0.9.29 #1053
There are some clippy lint fixes I was unsure about:
enum TrustedOperationOrHash<Hash>
as large (enum StreamState
as well) and suggested usingBoxed
values instead. I did so as the variantOperationEncoded(Vec<u8>)
is heap allocated as well. Is it okay or should this lint be surpressed?fn pruned
function'sline could be written as
However the
enclave-runtime
can not find this method:I suspect this might be due to SGX STD env, but I haven't confirmed it (yet), which is why I opted for skipping it.
This seems to come from one of our dependencies, which is why I added it to the allowlist.