Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering and Identifying Transfer Events in Enclave #1355

Merged
merged 13 commits into from
Aug 14, 2023
Merged

Filtering and Identifying Transfer Events in Enclave #1355

merged 13 commits into from
Aug 14, 2023

Conversation

coax1d
Copy link
Contributor

@coax1d coax1d commented Jun 12, 2023 •
edited
Loading

Addresses first bullet point for #1252

@coax1d coax1d self-assigned this Jun 12, 2023
@coax1d coax1d requested a review from clangenb June 15, 2023 06:52
@coax1d coax1d added A0-core Affects a core part B0-silent Item should not be mentioned in any change logs. (e.g. documentation updates) C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing labels Jun 15, 2023
@coax1d coax1d marked this pull request as ready for review June 15, 2023 06:53
@coax1d coax1d mentioned this pull request Jun 22, 2023
Merged
clangenb
clangenb reviewed Jul 3, 2023
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, in general it looks simple and easy! I have only some minor comments. :)

core/parentchain/indirect-calls-executor/src/event_filter.rs Outdated Show resolved Hide resolved
scripts/test_transfer/README.md
@@ -0,0 +1,6 @@
## Test transfer from Alice to random account
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For an intermediate solution, I shall accept the js-stuff, but I would like to stay consistent and only use our shell-rust integration tests. Also because what you implemented here is already possible with our current rust-cli.

I do think, however, that when we want to extend our integration testing suite, that a switch to js/ts is reasonable, but then with a holistic approach. :)

core/parentchain/indirect-calls-executor/src/event_filter.rs Outdated Show resolved Hide resolved
@clangenb
Merge branch 'master' into coax1d-listening-for-xsfer-events
11ed34b 
# Conflicts:
#	Cargo.lock
#	enclave-runtime/Cargo.lock
@clangenb clangenb force-pushed the coax1d-listening-for-xsfer-events branch from 09556cc to 11ed34b Compare August 14, 2023 08:56
clangenb
clangenb approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good, I have two minor suggestions, which I will quickly fix myself.

core/parentchain/indirect-calls-executor/src/event_filter.rs Outdated Show resolved Hide resolved
core/parentchain/indirect-calls-executor/src/event_filter.rs Outdated Show resolved Hide resolved
@clangenb clangenb merged commit 3359ea5 into master Aug 14, 2023
21 checks passed
@clangenb clangenb deleted the coax1d-listening-for-xsfer-events branch August 14, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees

@coax1d coax1d

Labels
A0-core Affects a core part B0-silent Item should not be mentioned in any change logs. (e.g. documentation updates) C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coax1d @clangenb