-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make enclave extrinsics mortal #1637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Only one remark:
- fall back to immortal, if last finalized header can't be obtained (is this dangerous?)
I don't think it is dangerous, the question is rather if it is realistic that the rest of the service if up and running well if we can't obtain it. I think the only possible scenario is if the parentchain is having finalization issues right at the time when the worker is starting up. Hence, we might consider falling back in this order: finalized head -> best head -> immortal. Not sure if it is worth implementing though.
closes #1475
approach:
ParentchainCall
type to include mortality info for each call separatelycritical:
balance_unshield
good to have to avoid jamming the chain after downtimes:
enclaveBridge.confirmProcessedParentchainBlock
sidechain.FinalizedSidechainBlock
only needed for init, low prio