make ParentchainApi generic to support Asset Hub #1650
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenzi
changed the title
brenzi
commented
Nov 14, 2024
Comment on lines
+70
to
+82
| pub trait ParentchainApiTrait: | ||
| AccountApi<AccountId = AccountId, Balance = Balance, Index = Index> | ||
| + GetBalance<Balance = Balance> | ||
| + GetStorage | ||
| + SystemApi<Properties = Properties> | ||
| + BalancesExtrinsics<Address = MultiAddress<AccountId, Index>, Balance = Balance> | ||
| + ChainApi | ||
| + GetAccountInformation<Index = Index> | ||
| + SubscribeEvents | ||
| + GetTransactionPayment<Balance = Balance> | ||
| + SubmitAndWatch<Hash = Hash> //+ GetRuntimeVersionAt<Block<Header, UncheckedExtrinsic<A>>> | ||
| { | ||
| } |
There was a problem hiding this comment.
this supertrait shall simplify using generic NodeApis, defined per Parentchain in app-libs
There was a problem hiding this comment.
I am a bit unsure about this trait. Even if we have it, I would only make it a trait bound in as few places as possible, as 99% of the times we only need part of it.
clangenb
reviewed
Nov 21, 2024
|
|
||
| pub type IntegriteeApi = Api<IntegriteeRuntimeConfig, TungsteniteRpcClient>; | ||
|
|
||
| impl ParentchainApiTrait for IntegriteeApi {} |
There was a problem hiding this comment.
Super traits are usually generically implemented for T satisfying all the constraints, i.e.,
impl<T> ParentchainApiTrait for T
where T: ....
{}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP. just wanted to know how far away we are. And we're not exactly near. reachable, but with effort
challenges: