This repository has been archived by the owner on Jan 7, 2023. It is now read-only.
Active manager is required as Ceph upgrades. #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If not manager is not active, Ceph health will report health_warn |
xuechendi
reviewed
Jun 15, 2018
deploy/mod/deploy.py
Outdated
| common.printout("LOG", "create mgr success: admin") | ||
| else: | ||
| common.printout("LOG", "not need create mgr") | ||
| common.pdsh(user, [head], "ceph auth get-or-create mgr.$name mon 'allow profile mgr' osd 'allow *' mds 'allow *' && ceph-mgr -i %s" % ceph_status["fsid"], option="console") |
There was a problem hiding this comment.
Can you add a check here, something like if active mgr no exists, then create?
The creation part looks perfect to me
|
Ok. let me add it.
Best Regards,
Ning
From: Chendi.Xue [mailto:[email protected]]
Sent: Friday, June 15, 2018 10:25 AM
To: 01org/CeTune <[email protected]>
Cc: Li, Ning <[email protected]>; Author <[email protected]>
Subject: Re: [01org/CeTune] Active manager is required as Ceph upgrades. (#298)
@xuechendi commented on this pull request.
________________________________
In deploy/mod/deploy.py<#298 (comment)>:
@@ -917,11 +917,8 @@ def start_mgr(self, force=False):
formatted_outStr = common.format_pdsh_return(outStr)
ceph_status = formatted_outStr[head]
#outList = [x.strip() for x in outStr.split('\n')]
- if "no active mgr" in outStr:
- common.pdsh(user, [head], "ceph auth get-or-create mgr.admin mon 'allow *' && ceph-mgr -i %s" % ceph_status["fsid"], option="console")
- common.printout("LOG", "create mgr success: admin")
- else:
- common.printout("LOG", "not need create mgr")
+ common.pdsh(user, [head], "ceph auth get-or-create mgr.$name mon 'allow profile mgr' osd 'allow *' mds 'allow *' && ceph-mgr -i %s" % ceph_status["fsid"], option="console")
Can you add a check here, something like if active mgr no exists, then create?
The creation part looks perfect to me
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#298 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AUP9FPSsy9pX0ruPeoujl9QiR75KHhGxks5t8xr5gaJpZM4Uo7JA>.
|
Fix a bug when calls translate_to_id() function. Signed-off-by: Li Ning <[email protected]>
Signed-off-by: Li Ning <[email protected]>
Signed-off-by: Li Ning <[email protected]>
Signed-off-by: Li Ning <[email protected]>
Signed-off-by: Li Ning <[email protected]>
Signed-off-by: Li Ning <[email protected]>
Signed-off-by: Li Ning <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active manager is required as Ceph upgrades. Also fix a bug when calls translate_to_id() function.
Signed-off-by: Li Ning [email protected]