Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vainfo: Print VAConfigAttribEncMaxTileRows and VAConfigAttribEncMaxTileCols #344

Merged
merged 1 commit into from
Oct 4, 2023
Merged

vainfo: Print VAConfigAttribEncMaxTileRows and VAConfigAttribEncMaxTileCols #344

merged 1 commit into from
Oct 4, 2023

Conversation

sivileri
Copy link
Contributor

@sivileri sivileri commented Sep 22, 2023 •
edited
Loading

Adds vainfo support for printing VAConfigAttribEncMaxTileRows and VAConfigAttribEncMaxTileCols

Depends on intel/libva#757

@dvrogozh @XinfengZhang

@sivileri sivileri changed the title vainfo: Print VAConfigAttribEncMaxTileRowsCols vainfo: Print VAConfigAttribEncMaxTileRows and VAConfigAttribEncMaxTileCols Sep 27, 2023
@sivileri sivileri mentioned this pull request Sep 27, 2023
Merged
dvrogozh
dvrogozh reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@dvrogozh dvrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the following to the commit message, please. Right before Signed-off-by:

Requires: https://github.com/intel/libva/pull/757
Signed-off-by: ...

-1 to make sure we won't merge PR before libva's one. Other than that change looks good to me.

@sivileri
Copy link
Contributor Author

sivileri commented Oct 2, 2023

@XinfengZhang kindly pinging on this MR :)

@XinfengZhang
Copy link
Contributor

please add #if VA_CHECK_VERSION(1, 21, 0) to make it work with older libva

@XinfengZhang XinfengZhang merged commit b080e23 into intel:master Oct 4, 2023
4 checks passed
@sivileri sivileri deleted the add_enc_max_tile_cols_rows branch March 27, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvrogozh dvrogozh dvrogozh left review comments

@XinfengZhang XinfengZhang XinfengZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sivileri @XinfengZhang @dvrogozh