av1encode: simplify cbr/vbr interface and refine codes #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leyu-yao
reviewed
Sep 27, 2023
1. Unify bitrate interface and remove buffer size related settings to use driver default values for best quality. 2. Remove extra empty lines for refining code. Signed-off-by: Xue, Maxim <[email protected]>
MaximIntel
force-pushed
the
av1_encoder_brc_refine
branch
from
a059172
to
12a7deb
Compare
MaximIntel
force-pushed
the
av1_encoder_brc_refine
branch
from
9734e12
to
2a56b0e
Compare
leyu-yao
approved these changes
Oct 26, 2023
XinfengZhang
approved these changes
Oct 27, 2023
Thanks @MaximIntel for updating PR, and it's nice to see it keeps to be backward compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use driver default values for best quality.
Signed-off-by: Xue, Maxim [email protected]