Fix VPP coverity issues #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex1Zhang
force-pushed
the
vpp-coverity
branch
from
82a6dd4
to
5603377
Compare
XinfengZhang
reviewed
Nov 9, 2023
videoprocess/vpphdr_tm.cpp
Outdated
| @@ -588,7 +590,9 @@ bool read_frame_to_surface(FILE *fp, VASurfaceID surface_id) | |||
| frame_size = va_image.width * va_image.height * 4; | |||
| src_buffer = (unsigned char*)malloc(frame_size); | |||
| assert(src_buffer); | |||
| fread(src_buffer, 1, frame_size, fp); | |||
| do {// | |||
There was a problem hiding this comment.
deadloop if the file is corrupted?
XinfengZhang
reviewed
Nov 9, 2023
videoprocess/vpphdr_tm.cpp
Outdated
| @@ -560,7 +560,9 @@ bool read_frame_to_surface(FILE *fp, VASurfaceID surface_id) | |||
|
|
|||
| src_buffer = (unsigned char*)malloc(frame_size); | |||
| assert(src_buffer); | |||
| fread(src_buffer, 1, frame_size, fp); | |||
| do{ | |||
| n_items = fread(src_buffer, 1, frame_size, fp); | |||
There was a problem hiding this comment.
what will happen if the src file is corrupted. and full size < frame_size?
There was a problem hiding this comment.
add log to check the return value instead of read in loop.
Signed-off-by: Alex1 Zhang [email protected]
Alex1Zhang
force-pushed
the
vpp-coverity
branch
from
5603377
to
35edf99
Compare
XinfengZhang
reviewed
Nov 9, 2023
| @@ -1236,10 +1236,6 @@ video_frame_process_scaling(VASurfaceID in_surface_id, | |||
| vaDestroyBuffer(va_dpy, pipeline_param_buf_id); | |||
| } | |||
|
|
|||
| if (filter_param_buf_id != VA_INVALID_ID) { | |||
There was a problem hiding this comment.
where to destroy filter_param_buf_id?
There was a problem hiding this comment.
trigger the deadcode error, this code always not be entered, so remove it.
XinfengZhang
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex1 Zhang [email protected]