Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Add tests for marray support in common and some math functions #1656

Open
wants to merge 4 commits into
base: intel
Choose a base branch
from

Conversation

dm-vodopyanov
Copy link

@dm-vodopyanov
Copy link
Author

/verify with intel/llvm#8631

@dm-vodopyanov
Copy link
Author

/verify with intel/llvm#8631

@dm-vodopyanov dm-vodopyanov requested a review from a team March 14, 2023 15:44
@KornevNikita
Copy link

/verify with intel/llvm#8631

sycl::marray<float, 3> ma5{180, -180, -180};

TEST(sycl::fabs, float, 3, EXPECTED(float, 180, 180, 180), 0, ma5);
TEST2(sycl::ilogb, float, 3, EXPECTED(int, 7, 7, 7), 0, ma3);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm missing something, this seems simpler:

Suggested change
TEST2(sycl::ilogb, float, 3, EXPECTED(int, 7, 7, 7), 0, ma3);
TEST(sycl::ilogb, int, 3, EXPECTED(int, 7, 7, 7), 0, ma3);

Then we can remove TEST2. Alternatively TEST2 could be defined using TEST to avoid code duplication.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ilogb takes floats and returns ints, so this is not the usual case where function takes T type and returns T type, so we can't do this change. However, TEST2 can be merged to TEST by adding one new argument to the TEST - the type of return value

AlexeySachkov pushed a commit to intel/llvm that referenced this pull request Mar 21, 2023
This patch adds marray support to all functions from Table 179 of SYCL
2020 spec + to functions fabs, ilogb, fmax, fmin, ldexp, pown, rootn
from Table 175 + to function exp10 from Table 177.

E2E tests: intel/llvm-test-suite#1656

---------

Co-authored-by: KornevNikita <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants