This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Reenable reduction tests and reinforce coverage #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reenables a selection of reduction tests that were only failing on certain systems. The failure was caused by reductions working outside its work boundaries and was passing due to the values read coincidentally being the same as the identity. To avoid this in the future, this commit also adds test-cases with a different actual identity. Signed-off-by: Larsen, Steffen <[email protected]>
sergey-semenov
approved these changes
Mar 14, 2023
|
/verify with intel/llvm#8641 |
Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm#8709 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reenables a selection of reduction tests that were only failing on certain systems. The failure was caused by reductions working outside its work boundaries and was passing due to the values read coincidentally being the same as the identity. To avoid this in the future, this commit also adds test-cases with a different actual identity.