Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added mtls support #361

Merged
merged 2 commits into from
May 21, 2024
Merged

feat: added mtls support #361

merged 2 commits into from
May 21, 2024

Conversation

alanjino
Copy link
Collaborator

@alanjino alanjino commented May 8, 2024

No description provided.

Copy link

dryrunsecurity bot commented May 8, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Configured Codepaths Analyzer 0 findings
Sensitive Files Analyzer 0 findings
Authn/Authz Analyzer 0 findings
AppSec Analyzer 0 findings
Secrets Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The code changes in this pull request focus on updating the Helm chart versions for the "agent" and "client" applications, as well as introducing support for mutual TLS (mTLS) authentication and improving the overall security and observability of the applications.

The key security-related changes include:

  1. mTLS Configuration: The code adds support for mTLS authentication, allowing for secure communication between the agent, client, and other components. This is a positive security enhancement, but it's important to ensure that the mTLS certificates are properly managed and rotated, and that the Kubernetes Secrets containing the certificates are secured with appropriate access controls.

  2. Secure Credential Management: The code uses environment variables and Kubernetes Secrets to manage sensitive information, such as the NATS token and Clickhouse database credentials, instead of hardcoding them in the deployment configuration. This is a recommended security practice.

  3. Monitoring and Observability: The code includes configurations for enabling monitoring and observability features, such as OpenTelemetry and various event consumers. This helps to improve the overall security posture of the application by allowing for better detection and response to potential security incidents.

Files Changed:

  • charts/agent/Chart.yaml: The Helm chart version for the "agent" application has been updated from "1.1.21" to "1.1.22". This is a routine update and does not introduce any security concerns.
  • charts/client/Chart.yaml: The Helm chart version for the "client" application has been updated from "1.1.27" to "1.1.28". This is also a routine update and does not raise any immediate security concerns.
  • charts/agent/values.yaml: The code adds a new section for configuring mTLS settings, including the ability to enable or disable mTLS and specify the Kubernetes Secret containing the necessary certificates and keys.
  • charts/agent/templates/deployment.yaml: The code adds support for mTLS authentication, including environment variables and volume mounts for the mTLS client certificates and CA certificate.
  • charts/client/values.yaml: The code adds new sections for configuring NATS TLS and mTLS settings, allowing for secure communication between the client and other components.
  • charts/client/templates/deployment.yaml: The code adds support for mTLS authentication, similar to the changes in the "agent" deployment, as well as configurations for NATS token, Clickhouse database, and various monitoring and observability features.

Powered by DryRun Security

@jebinjeb jebinjeb merged commit 3a90894 into intelops:main May 21, 2024
14 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants