-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Url phishing analysis framework #2552
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # requirements/project-requirements.txt
…l-phishing-analysis-framework
# Conflicts: # requirements/project-requirements.txt
…aybook-phishing-analysis
…hing_form_compiler.py Co-authored-by: Matteo Lodi <[email protected]>
api_app/analyzers_manager/file_analyzers/phishing/phishing_form_compiler.py
Fixed
Show fixed
Hide fixed
api_app/analyzers_manager/file_analyzers/phishing/phishing_form_compiler.py
Dismissed
Show dismissed
Hide dismissed
Regarding deepsource warning: https://github.com/tiran/defusedxml?tab=readme-ov-file#defusedxmllxml |
…l-phishing-analysis-framework
mlodic
reviewed
Nov 5, 2024
mlodic
requested changes
Nov 5, 2024
integrations/phishing_analyzers/analyzers/seleniumwire_request_serializer.py
Outdated
Show resolved
Hide resolved
integrations/phishing_analyzers/analyzers/seleniumwire_request_serializer.py
Outdated
Show resolved
Hide resolved
integrations/phishing_analyzers/analyzers/seleniumwire_request_serializer.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a framework for dumping information about web pages and interact with phishing pages.
Type of change
Please delete options that are not relevant.
Checklist
develop
dumpplugin
command and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zip
and you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERS
playbook by following this guide.url
that contains this information. This is required for Health Checks._monkeypatch()
was used in its class to apply the necessary decorators.MockUpResponse
of the_monkeypatch()
method. This serves us to provide a valid sample for testing.Black
,Flake
,Isort
) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.tests
folder). All the tests (new and old ones) gave 0 errors.DeepSource
,Django Doctors
or other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.Important Rules