Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Reenable HydraDX chopsticks tests #143

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Test: Reenable HydraDX chopsticks tests #143

merged 8 commits into from
Dec 21, 2023

Conversation

bvotteler
Copy link

@bvotteler bvotteler commented Dec 21, 2023

Resolves #138

Changes:

  • Reenable HydraDX chopsticks tests
  • Modify ED check for HydraDX only to bump minimal amount's fees by 10%

The second part is to avoid issues where fees required change due to previous test transactions since HydraDX uses the token/HDX pair for fees which can slip and lead to false negatives.

This bump by an arbitrary percentage (10%) isn't perfect, but would at least catch some cases where the ED changes by a value that's in excess of actual fees plus 10%.
Given our fee estimate is 10x and tests start failing when the estimate is less than 2x the actual fee, the minimum amount returned by the XCM bridge should still be large enough to cover small changes in ED not caught.

@bvotteler bvotteler requested a review from sander2 December 21, 2023 08:25
Copy link
Member

@sander2 sander2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your assessment. Not ideal, but good enough to catch problems as long as we maintain the 2x safety margin

@bvotteler bvotteler merged commit d092599 into interlay:master Dec 21, 2023
4 checks passed
@bvotteler bvotteler deleted the test-reenable-hydra-chopsticks branch December 21, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests: Check HydraDX chopsticks tests, reenable if improved in stability
2 participants