forked from polkawallet-io/bridge
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Make chopsticks tests more resilient #157
Merged
bvotteler
merged 11 commits into
interlay:master
from
bvotteler:test-separate-assethub-tests
Jan 18, 2024
Merged
Test: Make chopsticks tests more resilient #157
bvotteler
merged 11 commits into
interlay:master
from
bvotteler:test-separate-assethub-tests
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvotteler
changed the title
Test: Move AssetHub test cases to separate action steps in chopsticks tests
Test: Make chopsticks tests more resilient
Jan 17, 2024
tomjeatt
requested changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good—requested changes are typos
tomjeatt
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes to try and make XCM chopsticks tests more stable and avoid some critical errors (particularly for AssetHub adapters) from hiding other issues.
Changes:
Separate tests involving AssetHub from other XCM tests
And run those on a slightly different schedule as the pre-existing XCM tests to avoid rate limiting due to opening too many channels at once.
Reduce frequency of automated tests to every 2 hours (was: every hour)
This may alleviate some cases of rate limiting. In any event, given the significant amount of failures due to flakiness, we need to check in quite frequently anyway. So we do not gain much by running these tests every hour as opposed to every other hour.
Disable ParallelFi adapter for chopsticks tests
Something seems to have changed on their end while I was working on this fix. Chopsticks now refuses to launch for Parallel. Needs more work to investigate and fix Parallel in another PR.