Upstream #4
Open
Upstream #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The domain name doesn't need lower-casing because its guaranteed to be in all lowercase.
Liquid's BlockHeaders are not Copyable
As the `X-Total-Results` header, in reply to `GET /assets/registry`
tokio and hyper were not upgraded because hyperlocal doesn't support their latest versions.
Doing this doesn't affect the indexes, but may result in multiple duplciated entries showing in the `recent` transactions.
The full list of txids can get pretty huge and is not really useful.
Remove bitcoin network variants in liquid mode, forbid setting networks that mismatch the compile flags, and avoid nonsensical network conversions. This also fixes and optimizes genesis block hash calculation, which was broken in the prior commit in with the `electrum-discovery` feature.
Or stick with v0.25 when we are, for compatibility with rust-elements.
It depends on the latest rust-bitcoin v0.26 release, making the conditional rust-bitcoin dependency unnecessary.
It conflicted with Liquid.
(cherry picked from commit d9b1bb1)
Similarly to romanz@4f44a78 (cherry picked from commit 3b802fc)
itertools, socket2, prometheus, signal-hook, time, tiny_http, hyper, hyperlocal and tokio
This updates rocksdb itself from v6.11.4 to v6.20.3.
Also, update the tests to match the current DiscoveryManager implementation.
This was the case before the recent rust-elements version bump, the regression was introduced due to this change: ElementsProject/rust-elements@55bfea9#diff-6af9b0d0a45083ddc237f726aaf91cc0a3b0c3e2afe3c3f3f4cc50f82a163d39
(cherry picked from commit 1d619ed)
As was the case prior to rust-bitcoin/rust-bitcoin#271
The default Address FromStr implementation only works with the
built-in AddressParams::{LIQUID,ELEMENTS} network parameters.
This is the case in Liquid Testnet/Regtest, where the native asset is created using the 'initialfreecoins' option. The native asset id is still used to determine mining fees.
A regression introduced in v0.17.0 made `Value` incompatible with bincode: ElementsProject/rust-elements#96 This also requires downgrading rust-bitcoin to v0.26, to match the version used by rust-elements. This reverts commit df99d5e.
Using rust-elements from github, pending the release of ElementsProject/rust-elements#98 They were originally downgraded in e3a819e.
And fix some compatibility issues with the changes introduced in rust-bitcoin v0.28.
The EBCompact compatibility trait is no longer necessary, the `get` prefix was removed in ElementsProject/rust-elements#128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.