Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add testnet initialization script #554

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

chore: add testnet initialization script #554

wants to merge 35 commits into from

Conversation

sander2
Copy link
Member

@sander2 sander2 commented Jan 30, 2023 •
edited
Loading

Todo:

  • relay chain setup
  • amm curve pools
  • add interlay support (future pr)
  • (optional) some cleanup

bvotteler
bvotteler approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@bvotteler bvotteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just one question: Are we okay with all constructed markets pointing to kusama/kintsugi related currencies like KSM, KBTC, and KINT even if this is called with with-defaults-of="testnet-interlay" (or parachain-endpoint of interlay testnet)?

bvotteler
bvotteler reviewed Jan 30, 2023
View reviewed changes
scripts/init-testnet.ts Outdated
[{ Token: "KBTC" }, { ForeignAsset: 2 }, 20_000], // movr
[{ Token: "KINT" }, { ForeignAsset: 2 }, 35_000], // movr
];
const basicPoolSetup = pools.map(([token1, token2, reward]) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to explicitly indicate types for the tuple so TS knows which types to expect.
IIRC, it will think it could be any of the tuple's internal types, ie. treating the input as array of mixed types rather than a tuple.

@sander2
Copy link
Member Author

sander2 commented Jan 30, 2023

LGTM

Just one question: Are we okay with all constructed markets pointing to kusama/kintsugi related currencies like KSM, KBTC, and KINT even if this is called with with-defaults-of="testnet-interlay" (or parachain-endpoint of interlay testnet)?

Good point, I think I'll leave testnet-interlay for a future pr

gregdhill
gregdhill reviewed Jan 30, 2023
View reviewed changes
scripts/init-testnet.ts Outdated Show resolved Hide resolved
@sander2 sander2 force-pushed the chore/testnet-init-script branch from 830f310 to e1aaa5b Compare January 31, 2023 15:17
@gregdhill gregdhill force-pushed the chore/testnet-init-script branch from 10cff71 to c05843a Compare January 31, 2023 15:25
@sander2 sander2 force-pushed the chore/testnet-init-script branch from 34bfe03 to 7d2fb48 Compare February 3, 2023 18:03
@sander2 sander2 changed the base branch from master to wip-feat-amm February 3, 2023 18:04
sander2
sander2 commented Feb 3, 2023
View reviewed changes
scripts/init-testnet.ts Outdated
metaPoolId,
[
"10_000_000_000_000", // 10 KSM
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"10_000_000_000_000" gets interpreted as 140004000400040000

sander2
sander2 commented Feb 8, 2023
View reviewed changes
scripts/init-testnet.ts Outdated
{ Token: "KSM" },
{ Token: "KBTC" },
Copy link
Member Author

@sander2 sander2 Feb 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is the only one that need to change? Also, this not only impacts updateRewardSchedule, but also createPair and addLiquidity. Won't that create a problem? edit: looks like createPair and addLiquidity do sorting automatically. The first question is still open though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the index of the Token variant will come before ForeignAsset

@gregdhill gregdhill mentioned this pull request Feb 23, 2023
Merged
Base automatically changed from wip-feat-amm to master March 13, 2023 14:01
sander2 and others added 18 commits June 7, 2023 17:38
@sander2
chore: add testnet initialization script
ba81eac
@sander2
refactor: init-testnet refactoring
76eaee8
@sander2
chore(script): lending rewards
2993aaa
@sander2
chore(script): vksm and sksm
57cbd2d
@sander2
chore(script): basepool & metapool setup
ee85d6a
@sander2
chore(script): basepool & metapool rewards
cb77c96
@sander2
chore(script): fix basepool id
d5a8cae
@sander2
chore(script): as submitted
a26563a
@sander2
chore(script): fund faucet in foreign assets
9ae7e73
@sander2
chore(script): set client versions
d5e5b63
@sander2
chore: fund faucet in kbtc
a3673da
@gregdhill @sander2
chore: add liquidity to base and meta pools
0476374 
Signed-off-by: Gregory Hill <[email protected]>
@sander2
fix: usdt and moonriver coingecko ids
fd6521d
@gregdhill @sander2
chore: add liquidity to uniswap pools
6c18c49 
Signed-off-by: Gregory Hill <[email protected]>
@sander2
chore(script): add supply to loan markets
7ffcdcd
@sander2
chore(script): script fixes - tried on-chain
ba69980
@sander2
fix: amm liquidity amounts
797e9c2
@sander2
fix(script): reduce kbtc mints
ba590ce
@sander2 sander2 force-pushed the chore/testnet-init-script branch from cf927a3 to 28b69fa Compare June 7, 2023 15:39
@gregdhill gregdhill mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvotteler bvotteler bvotteler approved these changes

@gregdhill gregdhill gregdhill left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sander2 @gregdhill @bvotteler @daniel-savu