Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import keys into shared-v2 wallet #536

Open
wants to merge 1 commit into
base: kintsugi
Choose a base branch
from

Conversation

gregdhill
Copy link
Member

Current logic flow now:

  1. Fetch all currency specific Vaults
    1. Vault imports derivation key from master to shared and shared-v2
    2. Vault imports all keys from currency specific wallet to shared and shared-v2
    3. Sweep funds from currency specific wallet to shared
  2. Add issue keys to shared wallet
    1. Rescan using electrs if using pruned node
    2. Rescan using bitcoind remaining heights
  3. Add issue keys to shared-v2 wallet
    1. Rescan using electrs if using pruned node (only after last sweep - if it exists)
    2. Rescan using bitcoind remaining heights

Copy link
Member

@sander2 sander2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change you made is correct, but (1) I think we need to clear rescan cache (by renaming, as we did before), otherwise it's not going to find the utxos of the imported addresses, and (2) it's been a while since I last looked closely into this code so it's hard to be 100% sure we didn't miss something..

PS you also need to cargo fmt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants