-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vaults to squid #51
Comments
Would you like me to add onto the existing vault object in squid or is should this be an entirely new object? Lines 51 to 59 in e0ed448
If adding to this existing is this what you are looking for?
|
Adding it to the existing vault object is the right approach. Thank you! |
Sounds good! |
@nud3l The locked collateral in the dashboard displays the collateral as DOT. Is the collateral in the multi-collateral system all converted to DOT equivalent value for displaying here? |
No, there are individual dashboards for each collateral asset. The DOT is just due to Interlay only having DOT as collateral right now. See Kintsugi as an example: https://kintsugi.interlay.io/dashboard/vaults There's then a summary dashboard that converts all collateral assets to USD but that would be an add on and I'd consider it out of scope for this PR. |
Ok thanks that clears up all my confusion. |
Looks like the proposed goal does not included locked btc amount just the a pending btc amount. I feel that we need locked btc to calculation the collateratlization: |
great catch, I forgot to add it. |
@nud3l For the status issuing, Is this referring to |
Almost: StatusIssuing - Active or Inactive (just that part basically: https://github.com/interlay/interbtc/blob/master/crates/vault-registry/src/types.rs#L132) StatusCollateral - AboveSecureThreshold, BelowSecureThreshold, BelowPremiumRedeemThreshold, Liquidated. The parachain just tracks if a vault is liquidated but the UI/frontend would also track if a vault is above or below certain collateral thresholds as determined by the ones here: https://docs.interlay.io/#/vault/overview?id=collateral-thresholds |
Ok I see Active is a bool within the VaultStatus struct |
Goal
Add a
vaults
endpoint where we can the data available at https://app.interlay.io/dashboard/vaultsImplementation
Vaults have:
Replaces
The text was updated successfully, but these errors were encountered: