[BREAKING] feat: adding vault issuing active event #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
changed the title
sander2
previously approved these changes
Mar 8, 2023
There was a problem hiding this comment.
lgtm. @gregdhill do you have any objections to merging this?
No we can even already include this in the next release, need to run |
|
I ran cargo fmt and pushed the changes |
gregdhill
reviewed
Mar 30, 2023
crates/vault-registry/src/types.rs
Outdated
| @@ -513,6 +513,10 @@ impl<T: Config> RichVault<T> { | |||
| pub(crate) fn set_accept_new_issues(&mut self, accept_new_issues: bool) -> DispatchResult { | |||
| self.update(|v| { | |||
| v.status = VaultStatus::Active(accept_new_issues); | |||
| Self::deposit_event(Event::<T>::ActiveVault { | |||
There was a problem hiding this comment.
Import Event in the header or use crate::Event here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over on the squid side of things, I need to know when an change has been made to:
https://github.com/interlay/interbtc/blob/master/crates/vault-registry/src/types.rs#L132
so I added an event to be emitted when this state changes.
Here is a reference to what I am doing in the squid:
interlay/interbtc-squid#51 (comment)