Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Upgrade parachain 1.21.0 #61

Merged
merged 9 commits into from
Jan 17, 2023
Merged

Feat: Upgrade parachain 1.21.0 #61

merged 9 commits into from
Jan 17, 2023

Conversation

bvotteler
Copy link
Contributor

@bvotteler bvotteler commented Jan 17, 2023

@gitguardian
Copy link

gitguardian bot commented Jan 17, 2023

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 09dcd8c src/mappings/encoding.ts View secret
- Generic High Entropy Secret 75cdaa7 src/mappings/encoding.ts View secret
- Generic High Entropy Secret 75cdaa7 src/mappings/encoding.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@bvotteler
Copy link
Contributor Author

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

This is a false positive. @ns212 can I override this, or do you have to do that?

@bvotteler bvotteler marked this pull request as ready for review January 17, 2023 10:30
@bvotteler bvotteler requested a review from peterslany January 17, 2023 10:30
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job updating the types properly and making the code cleaner! Only comment I left is regarding the naming, which is only a suggestion that can be ignored :)

Comment on lines +153 to +158
1. Ensure your DB is running and up to date (e.g. you recently ran `yarn db:migrate`)
2. Run `yarn gen:code` to regenerate TypeScript types for the GraphQL entities.
3. Run `yarn build` to compile the newly generated code.
4. Run `yarn db:create-migration`, and enter a name for the migration. This will auto-generate it.
5. Run `yarn db:migrate` to apply your new migration.
6. You can now develop the mappings against the new entities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update of the readme! 👏

schema.graphql Outdated Show resolved Hide resolved
@bvotteler
Copy link
Contributor Author

bvotteler commented Jan 17, 2023

Full indexing tested:

  • Interlay mainnet (runtime 1020001) ✅
  • Kintsugi mainnet (runtime 1020001) ✅
  • Interlay testnet (no plans to test)
  • Kintsugi testnet (runtime 1020000) ✅

@bvotteler bvotteler merged commit e0ed448 into interlay:master Jan 17, 2023
@bvotteler bvotteler deleted the feat-zenlink-amm branch January 17, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Squid to work with parachain 1.21.0 Workflow for updating the SQL schema is out of order.
2 participants