-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add cumulative dex volumes #81
Feat: Add cumulative dex volumes #81
Conversation
…dex metadata events
7-day, 24-hour volumes can be calculated using the cumulative volumes. See this comment for example queries. |
This is what a 7-day volume query could look like:
eg. using these parameter values
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the implementation 👏 Just left couple of comments to clarify some aspects - but nothing serious :)
…tring on entity ids for pools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bvotteler This looks good to me, approving now. This comment does not need to be handled as we are sure other types of currencies won't be used, right?
https://github.com/interlay/interbtc-squid/pull/81/files#r1106863865
Yes, I am assuming this holds true until our types are updated to include those. |
Split off from #35
Added cumulative volumes per pool, containing volume per token of the swap.
Resolves #80