feat: Add recovery pallet in runtime.

[nakul1010]

Closes #736

The Recovery Pallet in Substrate is a social recovery tool that allows users to regain account access through trusted friends' approval. It offers customizable configurations, safeguards, and efficient computational performance.

Key Points

• Utilizes M-of-N social recovery mechanism with Substrate for account access restoration.
• Users set a threshold of trusted friends for approving recovery attempts.
• Configurable parameters include friend selection, approval threshold, and delay period.
• Requires a deposit for creating a recovery configuration, refundable upon removal, and works based on game theory approach.
• Provides a secure process for initiating, vouching, and claiming account recovery.
• Allows updates to recovery configurations based on changing relationships and circumstances.
• Ensures account security by requiring consensus among trusted friends.
• Mitigates the risk of key loss or authentication issues, enhancing account security.

For more detailed information, refer to the Substrate documentation on Pallet Recovery.

Note: To enhance the adoption of the pallet among Interlay users, the implementation of a dedicated web app page is essential.

[gregdhill]

Thanks for looking into this @nakul1010! I've left a few comments on the Interlay runtime but please also consider those for the Kintsugi runtime. It's good that you already ran the benchmarks. In the PR description can you describe a bit about the functionality of the recovery pallet? Specifically how it works and what the benefits are.

[gregdhill]

How did you decide on these parameters?

[nakul1010]

I had taken reference from the frame config set, but after re-reviewing, I suggest setting one of the following configs defined below.

INTR Config based on KSM Config set

Current Market Price

1 KSM -> 25 USD 
1 INTR -> 0.0159 USD 

pub const ConfigDepositBase: Balance = 8 * Dollars; //0.0000000000125 USD

pub const FriendDepositFactor: Balance = 1 * Dollars; //0.00000000000125 USD

pub const MaxFriends: u16 = 9;

pub const RecoveryDeposit: Balance = 8 * Dollars; //0.0000000000125 USD

INTR Config based on Dollar, this

pub const ConfigDepositBase: Balance = 315 * Dollars; // if 1 INTR -> 0.0159 USD, this is equivalent to 5 Dollars

pub const FriendDepositFactor: Balance = 31 * Dollars; //this is equivalent to 0.5 Dollars

pub const MaxFriends: u16 = 9;

pub const RecoveryDeposit: Balance = 6300 * Dollars; // equivalent to 100 dollars, I recommend setting a larger value for the RecoveryDeposit compared to the ConfigDepositBase. 
// While many para chains set the RecoveryDeposit equal to the ConfigDepositBase, I suggest using a higher amount, 100 Dollars. 
// By increasing the RecoveryDeposit, we can ensure a more robust recovery process and mitigate the risk of unauthorized or malicious recoveries based on game theory.

[nakul1010]

Note: Polkadot yet not have added the recovery pallet into the runtime.

[gregdhill]

That makes sense to me!

[nud3l]

Aren't those values very very high? We require 250 vINTR for governance proposals and these would require a lot more INTR to actually use this feature. So only very few people could use this.

What's the downside of setting this to much lower values so that you could set this up with say max 500 INTR?

[nakul1010]

@nud3l, I agree that we can reduce the value of ConfigDepositBase to 100 INTR to make it more accessible. However, it is important to keep the RecoveryDeposit at a sufficiently high level. This is because the RecoveryDeposit amount is refunded if the recovery process is successful.

If we set the RecoveryDeposit value too low, there is a risk that a malicious rescuer could attempt to recover the account, and if the account holder cancels the recovery process, the malicious rescuer would only lose a minimal amount due to the low RecoveryDeposit value.

It's worth noting that the RecoveryDeposit only needs to be reserved if the account recovery process is on and not when setting up the account recovery.

[nakul1010]

Thanks for looking into this @nakul1010! I've left a few comments on the Interlay runtime but please also consider those for the Kintsugi runtime. It's good that you already ran the benchmarks. In the PR description can you describe a bit about the functionality of the recovery pallet? Specifically how it works and what the benefits are.

Done

[gregdhill]

@nud3l @sander2 thoughts on including this pallet?

[nud3l]

I'm in favor of including the pallet. @nakul1010 @gregdhill do you know other projects having a UI for this?

I do think the security deposits are too aggressive though for the feature to be useful. Left an extra comment there so we can discuss.

[nakul1010]

I'm in favor of including the pallet. @nakul1010 @gregdhill do you know other projects having a UI for this?

I do think the security deposits are too aggressive though for the feature to be useful. Left an extra comment there so we can discuss.

I couldn't find any team that has a dedicated user interface specifically for this pallet. However, you can find the flow documentation for the process on Polkadot's document website here.

[nud3l]

Ok, let me ask if somebody has already implemented a UI for this.

[nakul1010]

@gregdhill updated parameters based on the comment.