fix: don't mint kbtc in cancel_redeem for liquidated vault #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
force-pushed
the
fix/liquidated_cancel_redeem
branch
from
13cbc45 to
0c34fda
Compare
gregdhill
reviewed
Oct 18, 2023
sander2
force-pushed
the
fix/liquidated_cancel_redeem
branch
from
0c34fda to
c55ba41
Compare
gregdhill
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
cancel_redeemwe have two branches:Unfortunately this doesn't account for the case when the Vault is liquidated, which on reimburse would still send them the "to-be-burned" KBTC. However because the Vault is already liquidated there is insufficient collateral to back these tokens, they should be burned and the accounting on the liquidation vault should be updated to reflect the decreased issued tokens.