test: fee pool testing #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of changes to the tests that I made when investigating bugs related to nomination. The randomized tests are great at catching edge cases, but finding the root cause of failing tests can be a pain. To help with that, I refactored the randomized tests to output the actions that can then be re-imported to debug the problem.
I also changed the IdealRewardPool to keep intermediate results in fixedpoint numbers such that rounding errors don't accumulate as much. This was a bit of a problem when testing slashing.
The last addition is the inclusion of slashing in the randomized tests. This led to the discovery of #847 , so it's disabled for now.