-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hooks): add use-form hook and changes to related components #14
Conversation
🦋 Changeset detectedLatest commit: 3c9ad30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aec8dcd
to
d3103e0
Compare
d3103e0
to
bc140ec
Compare
bc140ec
to
28672ad
Compare
28672ad
to
9336a36
Compare
9336a36
to
6cb2e21
Compare
524974d
to
438b08e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Closes #12
📝 Description
use-form
hook1. add
getTokenFieldProps
: specific function forTokenInput
that required some changes on that component2. changes to
getSelectFieldProps
:blur
handler has moved in fromgetFieldProps
3. props that were passed in previous mentioned function, now are defined in hook level using
hideErrors
prop.4. add tests
TokenInput
which are related touse-form
(try here):1. added
onValueChange
: this event is not used to maintainuse-form
updated, instead of relying on manually triggerevent
2. improved
aria
: addedaria-controls
to balanceMAX
button which affects the input. When the input is affected by the button, the focus is set to the input. Why? Based on html native number input which has buttons that increment and decrement the input, when clicked, the focus is always set on the input. This is essencial because it allows external form apis do know that the input is being touched (this is achieved withonBlur
event).⛳️ Current behavior (updates)
TokenInput
: when the max button is triggered, focus is not set on the input🚀 New behavior
TokenInput
: focus is set on the input when max btn is triggered.