Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hooks): add use-currency-formatter #25

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

danielsimao
Copy link
Member

📝 Description

  • It's an approach to formatting usd value based on uniswap.
  • handles local under the hood using react-aria useLocale which is connected to their I18nProvider which we use in our InterlayUIProvider

⛳️ Current behavior (updates)

TokenInput does not handle small decimals

🚀 New behavior

Handles decimals until 10 digits, more digits are replaced with <$0.00000001

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023

🦋 Changeset detected

Latest commit: f9878bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@interlay/ui Patch
@interlay/hooks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 0:36am

Copy link
Contributor

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good—couple of very minor change requests relating to documentation/comments.

tomjeatt
tomjeatt previously approved these changes Oct 3, 2023
Copy link
Contributor

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@danielsimao danielsimao merged commit d039765 into main Oct 3, 2023
7 checks passed
@danielsimao danielsimao deleted the feat/use-currency-formatter branch October 3, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants