-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hooks): add use-currency-formatter #25
Conversation
🦋 Changeset detectedLatest commit: f9878bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8d36750
to
9b66015
Compare
9b66015
to
797a8a9
Compare
877b4de
to
d870784
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good—couple of very minor change requests relating to documentation/comments.
packages/hooks/src/use-currency-formatter/use-currency-formatter.tsx
Outdated
Show resolved
Hide resolved
535a556
to
f304974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
📝 Description
uniswap
.useLocale
which is connected to theirI18nProvider
which we use in ourInterlayUIProvider
⛳️ Current behavior (updates)
TokenInput
does not handle small decimals🚀 New behavior
Handles decimals until 10 digits, more digits are replaced with
<$0.00000001
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information