fix: resource server spec (#341)

* fix: resource server spec * fix: types * chore: changeset
interledger · Oct 20, 2023 · 2458bb9 · 2458bb9
1 parent 5c4efb0
commit 2458bb9
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/.changeset/neat-items-speak.md b/.changeset/neat-items-speak.md
@@ -0,0 +1,5 @@
+---
+'@interledger/open-payments': patch
+---
+
+Fix POST incoming payment response types.
diff --git a/openapi/resource-server.yaml b/openapi/resource-server.yaml
@@ -126,7 +126,8 @@ paths:
                     methods:
                       - type: ilp
                         ilpAddress: g.ilp.iwuyge987y.98y08y
-                        sharedSecret: 1c7eaXa4rd2fFOBl1iydvCT1tV5TbM3RW1WLCafu_JA'401'
+                        sharedSecret: 1c7eaXa4rd2fFOBl1iydvCT1tV5TbM3RW1WLCafu_JA
+        '401':
           $ref: '#/components/responses/401'
         '403':
           $ref: '#/components/responses/403'
@@ -1329,14 +1330,16 @@ components:
       in: header
       schema:
         type: string
-        example: 'Signature: sig1=:EWJgAONk3D6542Scj8g51rYeMHw96cH2XiCMxcyL511wyemGcw==:'
+        examples:
+          - 'Signature: sig1=:EWJgAONk3D6542Scj8g51rYeMHw96cH2XiCMxcyL511wyemGcw==:'
       description: 'The signature generated based on the Signature-Input, using the signing algorithm specified in the "alg" field of the JWK.'
     optional-signature-input:
       name: Signature-Input
       in: header
       schema:
         type: string
-        example: 'Signature-Input: sig1=("@method" "@target-uri" "content-digest" "content-length" "content-type");created=1618884473;keyid="gnap-rsa"'
+        examples:
+          - 'Signature-Input: sig1=("@method" "@target-uri" "content-digest" "content-length" "content-type");created=1618884473;keyid="gnap-rsa"'
       description: 'The Signature-Input field is a Dictionary structured field containing the metadata for one or more message signatures generated from components within the HTTP message.  Each member describes a single message signature.  The member''s key is the label that uniquely identifies the message signature within the context of the HTTP message.  The member''s value is the serialization of the covered components Inner List plus all signature metadata parameters identified by the label.  The following components MUST be included: - "@method" - "@target-uri" - "authorization".  When the message contains a request body, the covered components MUST also include the following: - "content-digest"  The keyid parameter of the signature MUST be set to the kid value of the JWK.      See [ietf-httpbis-message-signatures](https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-message-signatures#section-4.1) for more details.'
 security:
   - GNAP: []
diff --git a/packages/open-payments/src/openapi/generated/resource-server-types.ts b/packages/open-payments/src/openapi/generated/resource-server-types.ts
@@ -406,7 +406,12 @@ export interface operations {
     };
     responses: {
       /** Incoming Payment Created */
-      201: components["responses"]["401"];
+      201: {
+        content: {
+          "application/json": components["schemas"]["incoming-payment-with-methods"];
+        };
+      };
+      401: components["responses"]["401"];
       403: components["responses"]["403"];
     };
     /**