Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename payment pointer to wallet address #288

Merged
merged 8 commits into from
Sep 21, 2023
Merged

Conversation

njlie
Copy link
Contributor

@njlie njlie commented Sep 20, 2023

Changes proposed in this pull request

Replaces all mentions of 'payment pointer' with 'wallet address'.

Context

Fixes #286.

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023

🦋 Changeset detected

Latest commit: 603f748

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@interledger/open-payments Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@BlairCurrey BlairCurrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to bump the specs that changed too but looks good other than that

@BlairCurrey
Copy link
Contributor

looks like there will be stuff to rename in https://github.com/interledger/open-payments/pull/289/files

README.md Outdated Show resolved Hide resolved
packages/open-payments/README.md Outdated Show resolved Hide resolved
@njlie njlie force-pushed the nl-use-wallet-address branch from ecccb7c to a4b4faa Compare September 21, 2023 09:33
@njlie njlie force-pushed the nl-use-wallet-address branch from a4b4faa to 8745679 Compare September 21, 2023 13:17
@njlie njlie requested a review from omertoast September 21, 2023 13:18
@njlie njlie force-pushed the nl-use-wallet-address branch from d1d78f9 to 603f748 Compare September 21, 2023 13:36
@njlie njlie merged commit c1e5010 into main Sep 21, 2023
6 checks passed
@njlie njlie deleted the nl-use-wallet-address branch September 21, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

payment pointers -> wallet addresses
3 participants