Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove payment pointer from resource url #291

Merged
merged 11 commits into from
Sep 22, 2023

Conversation

njlie
Copy link
Contributor

@njlie njlie commented Sep 20, 2023

Changes proposed in this pull request

Removes the payment pointer prefix from all resource urls.

Context

Fixes #290.

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023

🦋 Changeset detected

Latest commit: a5fdb90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@interledger/openapi Minor
@interledger/open-payments Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@njlie njlie force-pushed the nl-remove-pp-from-resource-url branch from 3fd4cbf to 1dc17ed Compare September 21, 2023 12:45
@omertoast omertoast force-pushed the nl-remove-pp-from-resource-url branch from 1dc17ed to 7df4b85 Compare September 21, 2023 13:10
remove ilpStreamConnection and all associated schemas
to replace it with a broader "payment methods" implementation
for incoming payment
const SPEC =
'https://github.com/interledger/open-payments/raw/3930448672cfc678ec2bc02938566a316d83871c/open-api-spec.yaml'
const PATH = '/incoming-payments'
const SPEC = path.resolve(__dirname, '../../../openapi/resource-server.yaml')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editor's note: a later commit will pin this to a link to a specific commit of this file, like before.

@omertoast omertoast force-pushed the nl-remove-pp-from-resource-url branch from 98b697f to a5fdb90 Compare September 22, 2023 10:38
@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for openpayments-preview failed.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/openpayments-preview/deploys/650d7423bd92d5353e97710c

@omertoast omertoast merged commit 4e98e06 into main Sep 22, 2023
7 of 10 checks passed
@omertoast omertoast deleted the nl-remove-pp-from-resource-url branch September 22, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove payment pointer/wallet address from resource url
3 participants