Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks spec missing event schema #2920

Closed
brad-dow opened this issue Aug 29, 2024 · 2 comments · Fixed by #2978
Closed

Webhooks spec missing event schema #2920

brad-dow opened this issue Aug 29, 2024 · 2 comments · Fixed by #2978
Assignees
Labels
pkg: backend Changes in the backend package.

Comments

@brad-dow
Copy link
Contributor

In reviewing the webhooks spec, I noticed that it was missing the following:

  • Missing incomingPaymentCreated event
  • Missing amount schema defined (several properties reference it)
@brad-dow brad-dow added the pkg: backend Changes in the backend package. label Aug 29, 2024
@brad-dow brad-dow added this to Rafiki Aug 29, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Aug 29, 2024
@mkurapov mkurapov added good first issue Good for newcomers and removed good first issue Good for newcomers labels Sep 10, 2024
@oana-lolea oana-lolea moved this from Todo to In Progress in Rafiki Sep 13, 2024
@mkurapov
Copy link
Contributor

mkurapov commented Sep 17, 2024

@brad-dow

Missing amount schema defined (several properties reference it)

The schema isn't missing the amount field per se, it's linked from the shared Open Payments resource server schema which we pull in programmatically from the open-payments package. It could easily be standalone though, we just need to write out the full amount schema (not too bad).

Just a note: for this webhook spec, it's easy to remove the dependency on the OP resource server spec, but will be a different story for the IDP spec since we import a lot more from the OP auth server spec.

@mkurapov
Copy link
Contributor

mkurapov commented Sep 17, 2024

@oana-lolea maybe for now, we can just add the amount schema in the spec directly (without referencing the other spec). Since its just one object with three fields that I don't suppose would change, I'm not worried about diverging from the Open Payments specs.

This also means we can remove the copy-op-schemas (and postinstall scripts in backend).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: backend Changes in the backend package.
Projects
Status: Done
3 participants