Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added spec for 'incomingPaymentCreated' and schema for 'amount' in webhooks.yaml #2978

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

oana-lolea
Copy link
Contributor

Updated the webhooks.yaml for OpenAPI by adding spec for incomingPaymentCreated event and for amount schema. Removed postinstall and copy-op-schemas from backend scripts.

Changes proposed in this pull request

  • Added spec for incomingPaymentCreated event.
  • Added spec for amount schema.
  • Removed postinstall and copy-op-schemas scripts from backend.

Context

Added missing spec for incomingPaymentCreated event and amount schema in OpenAPI specs file, webhooks.yaml. This schema was already defined in the Open Payments resource server specs and copied using postinstall and copy-op-schemas scripts. These scripts were removed from package.json as they are no longer necessary.
This issue fixes #2920

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

…ved 'postinstall' and 'copy-op-schemas' scripts.
@oana-lolea oana-lolea requested a review from mkurapov September 17, 2024 13:34
@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic labels Sep 17, 2024
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 7115241
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66e99f252ec66300088c378e

Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one simplification

packages/backend/src/openapi/specs/webhooks.yaml Outdated Show resolved Hide resolved
@oana-lolea oana-lolea merged commit 60c06cc into main Sep 18, 2024
30 of 42 checks passed
@oana-lolea oana-lolea deleted the 2920-webhooks-spec-update branch September 18, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: backend Changes in the backend package. type: source Changes business logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhooks spec missing event schema
2 participants