chore: upgrade to typescript 5 #2345

BlairCurrey · 2024-01-16T17:55:52Z

Changes proposed in this pull request

upgrades typescript to 5.3.3 and fixes a resulting build error

Context

chore(deps): update dependency typescript to v5 - autoclosed #1243

Checklist

fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators

forceConsistentCasingInFileNames defaults to true in ts 5.0

netlify · 2024-01-16T17:55:57Z

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name	Link
🔨 Latest commit	`1e8bfbb`
🔍 Latest deploy log	https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/65b1286b4b877900076dd090

BlairCurrey · 2024-01-16T18:31:22Z

packages/auth/src/graphql/scalars/UInt8.ts

@@ -10,7 +10,7 @@ function coerceUInt8Value(value: number | string | unknown): number {
    throw new TypeError('Provided value is not number or string.')
  }
  const nValue = Number(value)
-  if (Number.isInteger(nValue) && value >= 0 && value <= 255) {
+  if (Number.isInteger(nValue) && nValue >= 0 && nValue <= 255) {


(same change made in backend)

fixes new rule: Forbidden Implicit Coercions in Relational Operators

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators

BlairCurrey · 2024-01-16T18:31:42Z

packages/auth/src/tests/context.ts

-      // Only accepts Middleware<DefaultState, DefaultContext> for some reason, koa is Middleware<DefaultState, AppContext>
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      koa as any
+      koa


I found that this "any" assertion wasn't needed

BlairCurrey · 2024-01-16T18:34:14Z

packages/frontend/tsconfig.json

@@ -10,7 +10,6 @@
    "target": "ES2019",
    "strict": true,
    "allowJs": true,
-    "forceConsistentCasingInFileNames": true,


(same change made a few other places)

forceConsistentCasingInFileNames is now true by default so I removed this because its now redundant. Just wanted to clarify that this isnt changing the configuration.

BlairCurrey · 2024-01-16T18:40:44Z

I also went through the list of settings being deprecated and found that we are not using any of them: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#deprecations-and-default-changes

sabineschaller

Thank you @BlairCurrey ! Just one small question.

sabineschaller · 2024-01-22T10:03:38Z

tsconfig.build.json

    /* Advanced Options */
    "skipLibCheck": true /* Skip type checking of declaration files. */,
-    "forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */,
+    // "forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */,
    "resolveJsonModule": true
  }
 }


Is there something off with the curly braces or why is that highlighted in red?

I think github's syntax highlighting for json just doesnt understand comments in json. You can see the same thing here for example: https://github.com/mui/material-ui/blob/4b735de27e84a0221f42530d281f6d718ee8a7e1/packages/mui-utils/tsconfig.build.json#L4

I see you're referring to the curly brace specifically... part of the same issue though it looks like. It's fine locally. As a sanity check I added an extra brace and that makes the build command fail. Which is not happening here in CI so I think we're good.

I removed the unused option for good measure but it doesnt change anything. looks like that's just the way it is on main too https://github.com/interledger/rafiki/blob/main/tsconfig.build.json

This is actually kinda weird, since some other tsconfigs with comments show the same way: https://github.com/yurtsiv/mermaid/blob/5d4d7c5fbfa21bc9d4974613fb7052144df336e0/todo-fix-root-level-tsconfig.json

while others do not: https://github.com/Ejden/vuetify/blob/1b8a04b9d936ba98d9e37ce711fd49aef53b1213/tsconfig.json

In the ones with red syntax highlighting the comma is at the end of the comment instead of the value. Not sure if thats the cause but prettier forces that on our end and it's just a display issue on github after all.

Thank you for digging so deep into this!

After you pointed it out it really bugged me that I wasn't entirely sure why this happens 😆

mkurapov · 2024-01-23T18:43:43Z

packages/backend/package.json

@@ -42,7 +42,7 @@
    "testcontainers": "^10.5.0",
    "tmp": "^0.2.1",
    "ts-node": "^10.9.2",
-    "typescript": "^4.9.5"
+    "typescript": "^5.3.3"


do we actually need to specify this across all of the different packages, or is having it once in the root package.json enough?

chore: upgrade to typescript 5 (#2345) * feat: upgrade ts to 5.0 * fix(auth): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore(auth): rm unecessary type assertion * fix(backend): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore: rm default tsconfig option forceConsistentCasingInFileNames defaults to true in ts 5.0 * chore: update package versions * chore: rm unused optoin * chore: rm typescript dev dep from pacakges

* chore(frontend): update error boundaries to v2 * chore(frontend): update meta to v2 * chore(frontend): update headers to v2 * chore(frontend): update form method to v2 * chore(frontend): update to v2 dev server * chore(frontend): update server module format to v2 * feat(frontend): typecheck cmd * fix(frontend): type only import * feat(frontend): ugprade remix to v2 - upgrades all remix package versions - fixes breaking v2 change - removes v2 future flags - removes skipLibCheck from tsconfig * feat: add frontend typecheck to ci * chore(MASE): upgrade routes to remix v2 * chore(MASE): upgrade module format to v2 * chore(MASE): update to v2 dev server * chore(MASE): update headers to v2 * chore(MASE): update form method to v2 * chore(MASE): update meta to v2 * chore(MASE): update error/catch boundary to v2 * feat(MASE): upgrade remix to v2 * fix(MASE): ts errors * feat(MASE): add typecheck cmd to ci * fix(frontend, MASE): remix server start * fix(MASE): eslint * refactor(MASE): parseQueryString to URLSearchParams * Update .github/workflows/lint_test_build.yml Co-authored-by: Radu-Cristian Popa <[email protected]> * fix(frontend,MASE): update entry.server request handlers * chore(MASE): format * chore(MASE): rm unused quotes route * Revert "Merge branch 'main' into bc/1464/remix-v2-updates" This reverts commit f7149aa, reversing changes made to 41673bb. * chore: cherry pick merge commit after reverting in f7149aa chore: upgrade to typescript 5 (#2345) * feat: upgrade ts to 5.0 * fix(auth): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore(auth): rm unecessary type assertion * fix(backend): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore: rm default tsconfig option forceConsistentCasingInFileNames defaults to true in ts 5.0 * chore: update package versions * chore: rm unused optoin * chore: rm typescript dev dep from pacakges * fix(frontend,MASE): mobile view * fix(frontend): no flash on mobile * refactor: rework new cookie secure env var * fix: move env var declaration from dockerfile to compose * feat(backend): upgrade Rafiki to open payments package v6.5 (#2337) * feat(backend): upgrade to open payments 6.5 * refactor: one singleton for openApi specs * chore(deps): update dependency autoprefixer to ^10.4.17 (#2352) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update lockfile * chore: rm extra space * chore: rm unnecessary eslint ignore --------- Co-authored-by: Radu-Cristian Popa <[email protected]> Co-authored-by: Sabine Schaller <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: upgrade ts to 5.0 * fix(auth): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore(auth): rm unecessary type assertion * fix(backend): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore: rm default tsconfig option forceConsistentCasingInFileNames defaults to true in ts 5.0 * chore: update package versions * chore: rm unused optoin * chore: rm typescript dev dep from pacakges

* chore(frontend): update error boundaries to v2 * chore(frontend): update meta to v2 * chore(frontend): update headers to v2 * chore(frontend): update form method to v2 * chore(frontend): update to v2 dev server * chore(frontend): update server module format to v2 * feat(frontend): typecheck cmd * fix(frontend): type only import * feat(frontend): ugprade remix to v2 - upgrades all remix package versions - fixes breaking v2 change - removes v2 future flags - removes skipLibCheck from tsconfig * feat: add frontend typecheck to ci * chore(MASE): upgrade routes to remix v2 * chore(MASE): upgrade module format to v2 * chore(MASE): update to v2 dev server * chore(MASE): update headers to v2 * chore(MASE): update form method to v2 * chore(MASE): update meta to v2 * chore(MASE): update error/catch boundary to v2 * feat(MASE): upgrade remix to v2 * fix(MASE): ts errors * feat(MASE): add typecheck cmd to ci * fix(frontend, MASE): remix server start * fix(MASE): eslint * refactor(MASE): parseQueryString to URLSearchParams * Update .github/workflows/lint_test_build.yml Co-authored-by: Radu-Cristian Popa <[email protected]> * fix(frontend,MASE): update entry.server request handlers * chore(MASE): format * chore(MASE): rm unused quotes route * Revert "Merge branch 'main' into bc/1464/remix-v2-updates" This reverts commit f7149aa, reversing changes made to 41673bb. * chore: cherry pick merge commit after reverting in f7149aa chore: upgrade to typescript 5 (#2345) * feat: upgrade ts to 5.0 * fix(auth): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore(auth): rm unecessary type assertion * fix(backend): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore: rm default tsconfig option forceConsistentCasingInFileNames defaults to true in ts 5.0 * chore: update package versions * chore: rm unused optoin * chore: rm typescript dev dep from pacakges * fix(frontend,MASE): mobile view * fix(frontend): no flash on mobile * refactor: rework new cookie secure env var * fix: move env var declaration from dockerfile to compose * feat(backend): upgrade Rafiki to open payments package v6.5 (#2337) * feat(backend): upgrade to open payments 6.5 * refactor: one singleton for openApi specs * chore(deps): update dependency autoprefixer to ^10.4.17 (#2352) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update lockfile * chore: rm extra space * chore: rm unnecessary eslint ignore --------- Co-authored-by: Radu-Cristian Popa <[email protected]> Co-authored-by: Sabine Schaller <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: upgrade ts to 5.0 * fix(auth): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore(auth): rm unecessary type assertion * fix(backend): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore: rm default tsconfig option forceConsistentCasingInFileNames defaults to true in ts 5.0 * chore: update package versions * chore: rm unused optoin * chore: rm typescript dev dep from pacakges

* chore(frontend): update error boundaries to v2 * chore(frontend): update meta to v2 * chore(frontend): update headers to v2 * chore(frontend): update form method to v2 * chore(frontend): update to v2 dev server * chore(frontend): update server module format to v2 * feat(frontend): typecheck cmd * fix(frontend): type only import * feat(frontend): ugprade remix to v2 - upgrades all remix package versions - fixes breaking v2 change - removes v2 future flags - removes skipLibCheck from tsconfig * feat: add frontend typecheck to ci * chore(MASE): upgrade routes to remix v2 * chore(MASE): upgrade module format to v2 * chore(MASE): update to v2 dev server * chore(MASE): update headers to v2 * chore(MASE): update form method to v2 * chore(MASE): update meta to v2 * chore(MASE): update error/catch boundary to v2 * feat(MASE): upgrade remix to v2 * fix(MASE): ts errors * feat(MASE): add typecheck cmd to ci * fix(frontend, MASE): remix server start * fix(MASE): eslint * refactor(MASE): parseQueryString to URLSearchParams * Update .github/workflows/lint_test_build.yml Co-authored-by: Radu-Cristian Popa <[email protected]> * fix(frontend,MASE): update entry.server request handlers * chore(MASE): format * chore(MASE): rm unused quotes route * Revert "Merge branch 'main' into bc/1464/remix-v2-updates" This reverts commit f7149aa, reversing changes made to 41673bb. * chore: cherry pick merge commit after reverting in f7149aa chore: upgrade to typescript 5 (#2345) * feat: upgrade ts to 5.0 * fix(auth): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore(auth): rm unecessary type assertion * fix(backend): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore: rm default tsconfig option forceConsistentCasingInFileNames defaults to true in ts 5.0 * chore: update package versions * chore: rm unused optoin * chore: rm typescript dev dep from pacakges * fix(frontend,MASE): mobile view * fix(frontend): no flash on mobile * refactor: rework new cookie secure env var * fix: move env var declaration from dockerfile to compose * feat(backend): upgrade Rafiki to open payments package v6.5 (#2337) * feat(backend): upgrade to open payments 6.5 * refactor: one singleton for openApi specs * chore(deps): update dependency autoprefixer to ^10.4.17 (#2352) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update lockfile * chore: rm extra space * chore: rm unnecessary eslint ignore --------- Co-authored-by: Radu-Cristian Popa <[email protected]> Co-authored-by: Sabine Schaller <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: upgrade ts to 5.0 * fix(auth): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore(auth): rm unecessary type assertion * fix(backend): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore: rm default tsconfig option forceConsistentCasingInFileNames defaults to true in ts 5.0 * chore: update package versions * chore: rm unused optoin * chore: rm typescript dev dep from pacakges

* chore(frontend): update error boundaries to v2 * chore(frontend): update meta to v2 * chore(frontend): update headers to v2 * chore(frontend): update form method to v2 * chore(frontend): update to v2 dev server * chore(frontend): update server module format to v2 * feat(frontend): typecheck cmd * fix(frontend): type only import * feat(frontend): ugprade remix to v2 - upgrades all remix package versions - fixes breaking v2 change - removes v2 future flags - removes skipLibCheck from tsconfig * feat: add frontend typecheck to ci * chore(MASE): upgrade routes to remix v2 * chore(MASE): upgrade module format to v2 * chore(MASE): update to v2 dev server * chore(MASE): update headers to v2 * chore(MASE): update form method to v2 * chore(MASE): update meta to v2 * chore(MASE): update error/catch boundary to v2 * feat(MASE): upgrade remix to v2 * fix(MASE): ts errors * feat(MASE): add typecheck cmd to ci * fix(frontend, MASE): remix server start * fix(MASE): eslint * refactor(MASE): parseQueryString to URLSearchParams * Update .github/workflows/lint_test_build.yml Co-authored-by: Radu-Cristian Popa <[email protected]> * fix(frontend,MASE): update entry.server request handlers * chore(MASE): format * chore(MASE): rm unused quotes route * Revert "Merge branch 'main' into bc/1464/remix-v2-updates" This reverts commit f7149aa, reversing changes made to 41673bb. * chore: cherry pick merge commit after reverting in f7149aa chore: upgrade to typescript 5 (#2345) * feat: upgrade ts to 5.0 * fix(auth): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore(auth): rm unecessary type assertion * fix(backend): ts2365 build error fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators * chore: rm default tsconfig option forceConsistentCasingInFileNames defaults to true in ts 5.0 * chore: update package versions * chore: rm unused optoin * chore: rm typescript dev dep from pacakges * fix(frontend,MASE): mobile view * fix(frontend): no flash on mobile * refactor: rework new cookie secure env var * fix: move env var declaration from dockerfile to compose * feat(backend): upgrade Rafiki to open payments package v6.5 (#2337) * feat(backend): upgrade to open payments 6.5 * refactor: one singleton for openApi specs * chore(deps): update dependency autoprefixer to ^10.4.17 (#2352) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update lockfile * chore: rm extra space * chore: rm unnecessary eslint ignore --------- Co-authored-by: Radu-Cristian Popa <[email protected]> Co-authored-by: Sabine Schaller <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

BlairCurrey added 5 commits January 16, 2024 11:41

feat: upgrade ts to 5.0

42aeb23

fix(auth): ts2365 build error

0892a48

fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators

chore(auth): rm unecessary type assertion

caa39fe

fix(backend): ts2365 build error

aaa93f4

fixes Forbidden Implicit Coercions in Relational Operators https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#forbidden-implicit-coercions-in-relational-operators

chore: rm default tsconfig option

3a4e342

forceConsistentCasingInFileNames defaults to true in ts 5.0

github-actions bot added pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: auth Changes in the GNAP auth package. pkg: mock-ase labels Jan 16, 2024

Merge branch 'main' into bc/upgrade-ts

4043c3c

BlairCurrey commented Jan 16, 2024

View reviewed changes

BlairCurrey marked this pull request as ready for review January 16, 2024 18:38

BlairCurrey requested review from sabineschaller, njlie and mkurapov January 16, 2024 18:41

chore: update package versions

a49a622

sabineschaller reviewed Jan 22, 2024

View reviewed changes

chore: rm unused optoin

801687b

BlairCurrey requested a review from sabineschaller January 23, 2024 14:49

mkurapov previously approved these changes Jan 23, 2024

View reviewed changes

Merge branch 'main' into bc/upgrade-ts

38d742e

BlairCurrey dismissed mkurapov’s stale review via 38d742e January 24, 2024 14:48

chore: rm typescript dev dep from pacakges

1e8bfbb

BlairCurrey requested a review from mkurapov January 24, 2024 15:15

mkurapov approved these changes Jan 24, 2024

View reviewed changes

BlairCurrey merged commit 8430b2c into main Jan 24, 2024
22 checks passed

BlairCurrey deleted the bc/upgrade-ts branch January 24, 2024 15:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade to typescript 5 #2345

chore: upgrade to typescript 5 #2345

BlairCurrey commented Jan 16, 2024 •

edited

Loading

netlify bot commented Jan 16, 2024 •

edited

Loading

BlairCurrey Jan 16, 2024

BlairCurrey Jan 16, 2024

BlairCurrey Jan 16, 2024

BlairCurrey commented Jan 16, 2024

sabineschaller left a comment

sabineschaller Jan 22, 2024

BlairCurrey Jan 22, 2024

BlairCurrey Jan 22, 2024 •

edited

Loading

BlairCurrey Jan 23, 2024

sabineschaller Jan 24, 2024

BlairCurrey Jan 25, 2024

mkurapov Jan 23, 2024 •

edited

Loading

chore: upgrade to typescript 5 #2345

chore: upgrade to typescript 5 #2345

Conversation

BlairCurrey commented Jan 16, 2024 • edited Loading

Changes proposed in this pull request

Context

Checklist

netlify bot commented Jan 16, 2024 • edited Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BlairCurrey commented Jan 16, 2024

sabineschaller left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BlairCurrey Jan 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkurapov Jan 23, 2024 • edited Loading

Choose a reason for hiding this comment

BlairCurrey commented Jan 16, 2024 •

edited

Loading

netlify bot commented Jan 16, 2024 •

edited

Loading

BlairCurrey Jan 22, 2024 •

edited

Loading

mkurapov Jan 23, 2024 •

edited

Loading