fix: fix incorrect loading of admin ui settings page #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
mkurapov
previously approved these changes
Jul 12, 2024
| @@ -39,7 +43,7 @@ export const loader = async ({ request }: LoaderFunctionArgs) => { | |||
|
|
|||
| return { responseData } | |||
| } else { | |||
| return redirect( | |||
| return redirectDocument( | |||
There was a problem hiding this comment.
is this the only place this is needed?
There was a problem hiding this comment.
We only found issue with the settings page.
There was a problem hiding this comment.
@mkurapov is actually a very good question. It made me realise that we need to make improvements on catching direct references to the login page and account recovery page as well! Both were already redirecting to the kratos endpoint when the login / Forgot password? buttons were clicked but weren't handling direct navigation optimally and should also be using redirectDocument if they are navigated to directly instead of just throwing an error.
I'm going to include an additional commit now that covers this as well.
golobitch
previously approved these changes
Jul 12, 2024
golobitch
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
redirectwithredirectDocument.We are using a nightly build to test if this resolves issues in possible production deployments.
Context
Checklist
fixes #number