feat(2737): add fees as metric for outgoing payment. #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: tests
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
pkg: documentation
JoblersTune
reviewed
Aug 7, 2024
packages/backend/src/open_payments/payment/outgoing/service.test.ts
Outdated
Show resolved
Hide resolved
JoblersTune
reviewed
Aug 7, 2024
localenv/telemetry/grafana/provisioning/dashboards/example.json
Outdated
Show resolved
Hide resolved
JoblersTune
reviewed
Aug 7, 2024
JoblersTune
reviewed
Aug 7, 2024
JoblersTune
reviewed
Aug 7, 2024
# Conflicts: # localenv/telemetry/grafana/provisioning/dashboards/example.json
mkurapov
reviewed
Aug 14, 2024
packages/backend/src/open_payments/payment/outgoing/lifecycle.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/open_payments/payment/outgoing/lifecycle.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/open_payments/payment/outgoing/lifecycle.ts
Outdated
Show resolved
Hide resolved
mkurapov
approved these changes
Aug 14, 2024
mkurapov
approved these changes
Aug 14, 2024
sabineschaller
pushed a commit
that referenced
this pull request
Aug 15, 2024
* feat(2737): add fees as metric for outgoing payment. * feat(2737): rename to payment_fees. * feat(2737): test case updates. * feat(2737): formatting. * feat(2737): re-order test cases. Move fee collector. * feat(2737): dashboard and doc updates. * feat(2737): merged with main. * feat(2737): review feedback applied from @JoblersTune. * feat(2737): review feedback applied from @mkurapov. * feat(2737): additional tests for covert of assets and rates. * feat(2737): additional tests ensuring the increment counter was called. * feat(2737): additional tests ensuring the increment counter was called. * feat(2737): readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
See issue #2737
Checklist
fixes #numberBruno collection updated