refactor(backend): update rate caching #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: tests
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
mkurapov
commented
Aug 26, 2024
| return rates | ||
| throw new Error(errorMessage) | ||
| } finally { | ||
| delete this.inProgressRequests[baseAssetCode] |
There was a problem hiding this comment.
@BlairCurrey this is the line that fixes the error
mkurapov
commented
Aug 26, 2024
Comment on lines
-83
to
-89
| const isCloseToExpiry = | ||
| cachedExpiry.getTime() < | ||
| Date.now() + 0.5 * this.deps.exchangeRatesLifetime | ||
|
|
||
| if (isCloseToExpiry) { | ||
| this.fetchNewRatesAndCache(baseAssetCode) // don't await, just get new rates for later | ||
| } |
There was a problem hiding this comment.
This didn't make sense, using this.fetchNewRatesAndCache(baseAssetCode) without await just turns it into a sync method, which was still making the request and not "prefetching it".
Now in the the new changes its a simple flow: if the rate is cached, return it, if not, get new rates. No need to check for "isCloseToExpiry"
BlairCurrey
approved these changes
Aug 26, 2024
golobitch
added a commit
that referenced
this pull request
Sep 2, 2024
* refactor(backend): update rate caching (#2891) * chore(localenv): fix startup migration (#2897) * feat(backend): add trace to outgoing payment lifecycle (#2884) * feat(backend): add trace to outgoing payment lifecycle * feat(backend): encapsulate query lookup in trace * chore(localenv): remove traces from default localenv --------- Co-authored-by: Max Kurapov <[email protected]> * Add migration files * Update migration files * Fix file name for migrations * feat(tenant): basic tenant admin api schema and service * Remove cascade deletion * feat(auth): create basic tenant service and model plus graphql schema * feat(graphql): generated data * feat(graphql): add create tenant resolver and call service and update graphql schema * feat(auth): add basic tenant schema and appropriate resources like model and service * feat(generated): graphql schema * feat(auth): add tenant id to create tenant input * feat(auth): rename tenant id and add basic logic for calling create tenant service * feat(auth): add basic create tenant functionality in service * Add tenant model in backend * feat(backend): add apollo client do dependencies * feat(auth): add delete tenant mutation to the schema * feat(auth): delete tenant * Add tenantId field on resources models, update migration * chore(auth): format * feat(backend): create tenant service implementation * feat(auth): codegen for putting generated files to backend * feat(packages): make multi tenant work wip * feat(mock-lib): add tenants to the seeding step * feat(backend): update resolvers with tenant id and finish the tenant creation * feat(localenv): update seed and docker compose * feat(generated): graphql schema * feat(bruno): admin auth create tenant mutation * feat(backend): small changes to schema + mapping of tenant to graphql + bruno * feat(everything): move endpoints to separate service, update bruno and schema do pagination and stuff --------- Co-authored-by: Max Kurapov <[email protected]> Co-authored-by: Nathan Lie <[email protected]> Co-authored-by: bsanduc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Delete the inflight request caching if we end up erroring. This is the
inProgressRequestsmap in the rates service.Context
fixes #2877
Checklist
fixes #number