Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always pass in identifier into token introspection #2907

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix: always pass in identifier into token introspection #2907

merged 2 commits into from
Aug 27, 2024

Conversation

mkurapov
Copy link
Contributor

@mkurapov mkurapov commented Aug 27, 2024 •
edited
Loading

Changes proposed in this pull request

Update token introspection to always pass in identifier instead of just during outgoing payments, this fixes an issue when doing token introspection for incoming payment grant with identifiers

Slack thread

Context

Fixes #2906

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. type: source Changes business logic pkg: auth Changes in the GNAP auth package. labels Aug 27, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 27, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 7b13d22
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66cde68b4d3833000828cd95

@mkurapov mkurapov changed the title 2906/mk/fix token introspection hotfix: always pass in identifier into token introspection Aug 27, 2024
@mkurapov mkurapov changed the title hotfix: always pass in identifier into token introspection chore: always pass in identifier into token introspection Aug 27, 2024
@mkurapov mkurapov changed the title chore: always pass in identifier into token introspection chore: always pass in identifier into token introspection (hotfix) Aug 27, 2024
@mkurapov mkurapov changed the title chore: always pass in identifier into token introspection (hotfix) fix: always pass in identifier into token introspection (hotfix) Aug 27, 2024
@mkurapov mkurapov changed the title fix: always pass in identifier into token introspection (hotfix) fix: always pass in identifier into token introspection Aug 27, 2024
@mkurapov mkurapov marked this pull request as ready for review August 27, 2024 14:58
@mkurapov mkurapov requested a review from njlie August 27, 2024 14:58
@mkurapov mkurapov merged commit e20228f into main Aug 27, 2024
42 checks passed
@mkurapov mkurapov deleted the 2906/mk/fix-token-introspection branch August 27, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlie njlie njlie approved these changes

Assignees
No one assigned
Labels
pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hotfix] cannot introspect incoming-payment grants with included identifier
2 participants
@mkurapov @njlie