chore: bump seed timeout #2911
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,8 +25,10 @@ services: | |
| - ../happy-life-bank/seed.yml:/workspace/seed.yml | ||
| - ../happy-life-bank/private-key.pem:/workspace/private-key.pem | ||
| depends_on: | ||
| happy-life-backend: | ||
| condition: service_healthy | ||
| cloud-nine-mock-ase: | ||
| condition: service_started | ||
| happy-life-backend: | ||
| hostname: happy-life-bank-backend | ||
| image: rafiki-backend | ||
|
|
@@ -69,6 +71,13 @@ services: | |
| KEY_ID: 53f2d913-e98a-40b9-b270-372d0547f23d | ||
| depends_on: | ||
| - cloud-nine-backend | ||
| healthcheck: | ||
| test: ["CMD", "wget", "--header=apollo-require-preflight: true", "http://localhost:3001/graphql?query=%7B__typename%7D", "-O", "/dev/null"] | ||
|
There was a problem hiding this comment. To confirm, this is just making an empty GQL request > what does this header do? There was a problem hiding this comment.
Yes, empty gql request. the header is to ensure CSRF protection doesnt block it. Took this request from apollo server docs here which mentions the header: https://www.apollographql.com/docs/apollo-server/monitoring/health-checks/ |
||
| start_period: 60s | ||
| start_interval: 5s | ||
| interval: 30s | ||
| retries: 1 | ||
| timeout: 3s | ||
| happy-life-auth: | ||
| hostname: happy-life-bank-auth | ||
| image: rafiki-auth | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why we had the
cloud-nine-mock-asedependency originally, do we need it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was introduced in #1812. All
happy-lifeservices depend on thecloud-nineones to avoid building the same images twice. If we remove thedepends_on, on a fresh localenv startup all the images will build two times since they are not found locally.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks @raducristianpopa !