Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): make payment retry attempts configurable via env #3028

Merged
merged 1 commit into from
Oct 14, 2024
Merged

feat(backend): make payment retry attempts configurable via env #3028

merged 1 commit into from
Oct 14, 2024

Conversation

dead8309
Copy link
Contributor

@dead8309 dead8309 commented Oct 11, 2024 •
edited
Loading

Changes proposed in this pull request

  • Added a new ENV MAX_OUTGOING_PAYMENT_RETRY_ATTEMPTS for configuring the number of payment sending attempts, with a default value of 5.

Context

Checklist

  • Related issues linked using fixes #3017
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic labels Oct 11, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 11, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit bb950fb
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/670cfe49d10c3400083589ee

mkurapov
mkurapov reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

packages/backend/src/config/app.ts Outdated Show resolved Hide resolved
@dead8309 dead8309 force-pushed the 3017-configure-payment-sending-attempts branch from a07d062 to d68d833 Compare October 14, 2024 10:35
@dead8309 dead8309 requested a review from mkurapov October 14, 2024 10:36
mkurapov
mkurapov previously approved these changes Oct 14, 2024
View reviewed changes
@mkurapov
Copy link
Contributor

Just need to run pnpm format

@dead8309
feat(backend): make payment retry attempts configurable via env
bb950fb 
- Closes #3017
- rename config variable to a proper name
- fix formatting
@dead8309 dead8309 force-pushed the 3017-configure-payment-sending-attempts branch from d68d833 to bb950fb Compare October 14, 2024 11:19
@mkurapov mkurapov mentioned this pull request Oct 14, 2024
Closed
1 task
@mkurapov mkurapov merged commit 76a5d00 into interledger:main Oct 14, 2024
30 of 42 checks passed
@dead8309 dead8309 deleted the 3017-configure-payment-sending-attempts branch October 14, 2024 13:54
@vineelreddy
Copy link

@dead8309, could you share your email ID? We'd like to send you something as a thank you for your contribution!

@dead8309
Copy link
Contributor Author

Hi @vineelreddy

It's [email protected]

Thanks🫣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted pkg: backend Changes in the backend package. type: source Changes business logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure payment sending attempts
3 participants
@dead8309 @mkurapov @vineelreddy