-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Admin UI error Auth redirect #3047
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
DarianM
changed the title
change href with redirectDocument
fix: Admin UI error Auth redirect
Oct 27, 2024
mkurapov
previously approved these changes
Oct 31, 2024
mkurapov
previously approved these changes
Nov 1, 2024
JoblersTune
reviewed
Nov 4, 2024
Login | ||
</Button> | ||
<Form method='post'> | ||
<Button aria-label='logout' type='submit' className='mr-2'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
<Button aria-label='logout' type='submit' className='mr-2'> | |
<Button aria-label='login' type='submit' className='mr-2'> |
@DarianM thanks for the fix! Would you mind please moving the action function below the default export function to match the styling throughout the |
mkurapov
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Using the
Form
withredirectDocument(loginUrl);
By using remix'saction
function andredirectDocument
instead ofhref
, the server processes the request, retrieves the necessary information (such as flow parameters from Ory Kratos), and provides the correct redirect response. The form submit allows remix to handle this routing server-side, ensuring the full URL is correctly generated.The
href
attribute instead tries to directly navigate to the link client-side. If variables.kratosBrowserPublicUrl is undefined or not available at runtime, Remix will interpret it asundefined
, creating thelocalhost:3010/undefined/self-service/login/browser
URL.Context
What were you trying to do?
fixes #2840