Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend)!: liquidityThresholdHigh for assets and peers #3085

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

golobitch
Copy link
Collaborator

@golobitch golobitch commented Nov 6, 2024

Changes proposed in this pull request

  • Rename liquidityThreshold that is used in peers and assets to liquidityThresholdLow
  • Add additional liquidityThresholdHigh to assets and peers
  • Two new webhook events for liquidityThresholdHigh for peers and assets

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary) docs: add new webhook event types #3092
  • OpenAPI specs updated (if necessary)

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 750cb07
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/67390e3d46e35c0008940202

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase pkg: mock-account-service-lib labels Nov 6, 2024
@golobitch golobitch force-pushed the feature/3012-liquidity-high-peers-assets branch from 5837636 to 553e684 Compare November 6, 2024 21:11
@golobitch golobitch force-pushed the feature/3012-liquidity-high-peers-assets branch 2 times, most recently from f8a4d1d to 01f0728 Compare November 7, 2024 20:24
@golobitch golobitch force-pushed the feature/3012-liquidity-high-peers-assets branch from 01f0728 to dc11aaf Compare November 7, 2024 20:26
@golobitch golobitch marked this pull request as ready for review November 7, 2024 21:16
@golobitch golobitch requested a review from mkurapov November 7, 2024 21:16
@golobitch golobitch self-assigned this Nov 7, 2024
@mkurapov mkurapov requested a review from oana-lolea November 12, 2024 12:27
@oana-lolea
Copy link
Contributor

Shouldn't frontend package be updated as well? Or is that planned in another PR/issue?

@golobitch golobitch force-pushed the feature/3012-liquidity-high-peers-assets branch from f3d5353 to 750cb07 Compare November 16, 2024 21:27
@golobitch
Copy link
Collaborator Author

Shouldn't frontend package be updated as well? Or is that planned in another PR/issue?

I think that I have updated everything now. Do you have maybe something specific in mind ?

@oana-lolea
Copy link
Contributor

I think these changes should reflect on Rafiki Admin as well, right?

On Webhook events page, the filter should be updated with peer_liquidityThresholdHigh and asset_liquidityThresholdHigh options.

Also, liquidityHighThreshold input should be added to create and update pages for assets and peers.

@mkurapov mkurapov added the breaking Issue/PR that introduces breaking changes label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Issue/PR that introduces breaking changes pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: source Changes business logic type: tests Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add peer liquidity high and asset liquidity high events
3 participants