-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fixes 3084 #3088
Merged
Merged
docs: fixes 3084 #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg: backend
Changes in the backend package.
type: source
Changes business logic
pkg: auth
Changes in the GNAP auth package.
pkg: documentation
Changes in the documentation package.
labels
Nov 6, 2024
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Continue Grant POST is for the Open Payments Auth API, so shouldn't be in the IdP spec |
mkurapov
reviewed
Nov 6, 2024
packages/documentation/src/content/docs/integration/requirements/wallet-addresses.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/src/content/docs/integration/requirements/wallet-addresses.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/src/content/docs/integration/requirements/wallet-addresses.mdx
Show resolved
Hide resolved
mkurapov
reviewed
Nov 12, 2024
packages/documentation/src/content/docs/integration/requirements/wallet-addresses.mdx
Outdated
Show resolved
Hide resolved
brad-dow
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg: auth
Changes in the GNAP auth package.
pkg: backend
Changes in the backend package.
pkg: documentation
Changes in the documentation package.
type: source
Changes business logic
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers doc issues that were discussed during a meeting with Max on Nov. 05, 2024.
@mkurapov Tagging you because of the YAML updates. Also, the OpenAPI spec for IdP is missing
Continue Grant POST /interact/{id}/{nonce}
. Is that intentional or should I create an issue for it?