Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixes #3052 #3091

Merged
merged 3 commits into from
Nov 8, 2024
Merged

docs: fixes #3052 #3091

merged 3 commits into from
Nov 8, 2024

Conversation

melissahenderson
Copy link
Contributor

Created to fix #3052, which is in response to #3050.

@oana-lolea I wasn't sure if every reference to --volumes should come out or only specific ones. Please take a look and let me know if I need to change anything!

@github-actions github-actions bot added type: localenv Local playground pkg: documentation Changes in the documentation package. labels Nov 7, 2024
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit cec101a
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/672df628b2abe900088e04a7

@oana-lolea
Copy link
Contributor

@melissahenderson I don't think the command should be removed entirely, because it may still be used. It should remain in the list of commonly used commands and removed only when it is used as a fix for the bug and as a setup command.

localenv/README.md Outdated Show resolved Hide resolved
@melissahenderson melissahenderson merged commit 5575ed0 into main Nov 8, 2024
42 checks passed
@melissahenderson melissahenderson deleted the mh-3052 branch November 8, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: documentation Changes in the documentation package. type: localenv Local playground
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update local environment setup commands
2 participants