Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: accts, idp, and disclosure component #3102

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

melissahenderson
Copy link
Contributor

@melissahenderson melissahenderson commented Nov 18, 2024

  • Updated the accounting concepts page.
  • Formatted the examples to be a bit easier to scan through. I'm working on revised examples outside of this PR.
  • Also made some updates to the IDP doc
  • Removed the use of the Disclosure component from the Webhook Events page and README. We are no longer using the component.

Before merging: Check status of Brad's peering guide. Links within my IdP and accounting pages need to point to the new services path.

When this is merged, I need to talk to Sarah about the Disclosure component.

Updated the accounting concepts page. Formatted the examples to be a bit easier to scan through. I'm working on revised examples outside of this PR. Also made some updates to the IDP doc and removed the use of the Disclosure component from the Webhook Events page and README. We are no longer using the component.
@melissahenderson melissahenderson added do not merge Do not merge PRs with these label user-docs labels Nov 18, 2024
@github-actions github-actions bot added the pkg: documentation Changes in the documentation package. label Nov 18, 2024
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit 3f03098
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/676197e6c18d5c0008528e64
😎 Deploy Preview https://deploy-preview-3102--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@melissahenderson
Copy link
Contributor Author

melissahenderson commented Nov 25, 2024

@mkurapov I updated the table formatting in the auth-variables page. That's why it shows so many edits.

Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDP page is ✅ , final comment

Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part of review of accounting page, might have some additional comments

Running prettier caused updates to a bunch of other files. The only file I edited in this iteration was the accounting file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge PRs with these label pkg: documentation Changes in the documentation package. user-docs
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants