Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update accountingTransfer limit to 20 #3115

Merged
merged 2 commits into from
Nov 28, 2024
Merged

chore: update accountingTransfer limit to 20 #3115

merged 2 commits into from
Nov 28, 2024

Conversation

oana-lolea
Copy link
Contributor

@oana-lolea oana-lolea commented Nov 21, 2024 •
edited
Loading

Changes proposed in this pull request

  • Updated limit for accountingTransfer to 20
  • Updated tests
  • Updated GraphQL description

Context

Fixes #3003

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@oana-lolea oana-lolea requested review from mkurapov and njlie November 21, 2024 09:50
@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. type: source Changes business logic labels Nov 21, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 21, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit d5b9e6d
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6745b1fcdcf4c40008ee63d0

njlie
njlie previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@njlie njlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oana-lolea oana-lolea merged commit 5de6208 into main Nov 28, 2024
30 of 42 checks passed
@oana-lolea oana-lolea deleted the 3003-default-limit-for-accounting-transfers branch November 28, 2024 11:56
njlie pushed a commit that referenced this pull request Dec 6, 2024
@oana-lolea @njlie
chore: update accountingTransfer limit to 20 (#3115)
976964a 
* Update accountingTransfer limit to 20

* Updated default value in PSQL, updated comments and descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

@njlie njlie njlie left review comments

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set default limit for accountingTransfers backend API
3 participants
@oana-lolea @mkurapov @njlie