Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Added state and expiry date to accounting transfer #3131

Merged
merged 8 commits into from
Dec 3, 2024
Merged

chore: Added state and expiry date to accounting transfer #3131

merged 8 commits into from
Dec 3, 2024

Conversation

oana-lolea
Copy link
Contributor

@oana-lolea oana-lolea commented Nov 25, 2024 •
edited
Loading

Changes proposed in this pull request

  • Added state and expiredAt fields to AccountingTransfer

Context

Added state and expiredAt fields to AccountingTransfer to reflect LedgerTransfer in the Admin API.
Fixes #3106

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@oana-lolea oana-lolea requested review from mkurapov and njlie November 25, 2024 13:12
@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase pkg: mock-account-service-lib labels Nov 25, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit eb3b552
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/674ed73ff90ddc0008678855

@mkurapov
Copy link
Contributor

Just need to update a test, otherwise good to go 👍

@oana-lolea oana-lolea merged commit 497d160 into main Dec 3, 2024
30 of 42 checks passed
@oana-lolea oana-lolea deleted the 3106-add-additional-fields-to-accounting-transfer branch December 3, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

@njlie njlie Awaiting requested review from njlie

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add additional fields to AccountingTransfers Admin API
2 participants
@oana-lolea @mkurapov