Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(backend): fix incrementCounterWithTransactionAmount function #3146

Merged
merged 1 commit into from
Dec 6, 2024
Merged

chore(backend): fix incrementCounterWithTransactionAmount function #3146

merged 1 commit into from
Dec 6, 2024

Conversation

mkurapov
Copy link
Contributor

@mkurapov mkurapov commented Dec 2, 2024 •
edited
Loading

Changes proposed in this pull request

  • Fix incrementCounterWithTransactionAmount metric collection

Context

Fixes #3145

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. type: source Changes business logic labels Dec 2, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit eccf2dd
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/674dfc31f90ddc00081ee589

@mkurapov mkurapov force-pushed the 3145/mk/fix-packet-amount-metric branch from d4f50ea to eccf2dd Compare December 2, 2024 18:27
@mkurapov mkurapov marked this pull request as ready for review December 2, 2024 19:34
@mkurapov mkurapov requested a review from BlairCurrey December 2, 2024 19:34
BlairCurrey
BlairCurrey reviewed Dec 5, 2024
View reviewed changes
packages/backend/src/telemetry/service.ts
: Number(converted)
this.incrementCounter(name, obfuscatedAmount, attributes)
const finalAmount = preservePrivacy
? privacy.applyPrivacy(Number(converted.amount))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah man... Number takes anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely feels like it should take in some proper types instead...

BlairCurrey
BlairCurrey approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@BlairCurrey BlairCurrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mkurapov mkurapov merged commit 6ef0a06 into main Dec 6, 2024
30 of 42 checks passed
@mkurapov mkurapov deleted the 3145/mk/fix-packet-amount-metric branch December 6, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlairCurrey BlairCurrey BlairCurrey approved these changes

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix transaction amount total telemetry collection
2 participants
@mkurapov @BlairCurrey