Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): wallet address creation page #3162

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix(frontend): wallet address creation page #3162

merged 1 commit into from
Dec 9, 2024

Conversation

mkurapov
Copy link
Contributor

@mkurapov mkurapov commented Dec 6, 2024 •
edited
Loading

Changes proposed in this pull request

  • Fix wallet address creation page by updating getOpenPaymentsUrl function to account for function running client-side

Context

Fixes #3161

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added the pkg: frontend Changes in the frontend package. label Dec 6, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 6, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 0c9e80d
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/67533293885d310008b7b2ae

@mkurapov mkurapov changed the title fit(frontend): fix getOpenPaymentsUrl function fit(frontend): wallet address creation page Dec 6, 2024
@mkurapov mkurapov changed the title fit(frontend): wallet address creation page fix(frontend): wallet address creation page Dec 6, 2024
@mkurapov mkurapov marked this pull request as ready for review December 6, 2024 17:27
@mkurapov mkurapov merged commit b83ac58 into main Dec 9, 2024
30 of 42 checks passed
@mkurapov mkurapov deleted the 3161/mk/fix-wallet-address-creation-page branch December 9, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oana-lolea oana-lolea oana-lolea approved these changes

@JoblersTune JoblersTune Awaiting requested review from JoblersTune

Assignees
No one assigned
Labels
pkg: frontend Changes in the frontend package.
Projects
Rafiki
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create wallet address in Admin UI
2 participants
@mkurapov @oana-lolea