Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run yt-dlp after brozzling a page (if at all) #276

Merged
merged 13 commits into from
Apr 24, 2024
Merged

run yt-dlp after brozzling a page (if at all) #276

merged 13 commits into from
Apr 24, 2024

Conversation

galgeek
Copy link
Contributor

@galgeek galgeek commented Apr 17, 2024 •
edited
Loading

brozzler should capture pages before video

avdempsey
avdempsey reviewed Apr 17, 2024
View reviewed changes
brozzler/ydl.py Outdated Show resolved Hide resolved
vbanos
vbanos reviewed Apr 18, 2024
View reviewed changes
brozzler/ydl.py Outdated Show resolved Hide resolved
@vbanos
Copy link
Contributor

vbanos commented Apr 18, 2024

Improvement suggestion: browse_page also gets the HTTP status of the response. You can access it via browser.websock_thread.page_status. If its not 200, you shouldn't run yt-dlp.

@vbanos
Copy link
Contributor

vbanos commented Apr 18, 2024

That's all from me, I think that this is a good improvement.

adam-miller
adam-miller reviewed Apr 23, 2024
View reviewed changes
brozzler/worker.py Outdated Show resolved Hide resolved
@galgeek galgeek merged commit 68c132a into internetarchive:master Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-miller adam-miller adam-miller approved these changes

@avdempsey avdempsey Awaiting requested review from avdempsey

@vbanos vbanos Awaiting requested review from vbanos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galgeek @vbanos @avdempsey @adam-miller